]> git.dujemihanovic.xyz Git - linux.git/commitdiff
drm/i915/gem: Return NULL instead of '0'
authorAndi Shyti <andi.shyti@linux.intel.com>
Mon, 17 Jun 2024 18:42:42 +0000 (20:42 +0200)
committerAndi Shyti <andi.shyti@linux.intel.com>
Thu, 20 Jun 2024 06:19:21 +0000 (08:19 +0200)
Commit 05da7d9f717b ("drm/i915/gem: Downgrade stolen lmem setup
warning") returns '0' from i915_gem_stolen_lmem_setup(), but it's
supposed to return a pointer to the intel_memory_region
structure.

Sparse complains with the following message:

>> drivers/gpu/drm/i915/gem/i915_gem_stolen.c:943:32: sparse: sparse:
   Using plain integer as NULL pointer

Return NULL.

Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Jonathan Cavitt <jonathan.cavitt@intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240617184243.330231-2-andi.shyti@linux.intel.com
drivers/gpu/drm/i915/gem/i915_gem_stolen.c

index 4d60a5b375053493aea9c380d82842e2d5b2599f..2f22306e9c0a698e49e5d017902883c19270a5c7 100644 (file)
@@ -940,7 +940,7 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type,
                        drm_dbg(&i915->drm,
                                "Disabling stolen memory support due to OOB placement: lmem_size = %lli vs dsm_base = %lli\n",
                                lmem_size, dsm_base);
-                       return 0;
+                       return NULL;
                }
                dsm_size = ALIGN_DOWN(lmem_size - dsm_base, SZ_1M);
        }