]> git.dujemihanovic.xyz Git - linux.git/commitdiff
drm/i915: Remove unnecessary goto in intel_primary_plane_disable()
authorAnder Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Thu, 27 Nov 2014 13:32:34 +0000 (15:32 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 3 Dec 2014 08:35:28 +0000 (09:35 +0100)
The same logic can be implemented without it, and it even saves a line
of code.

Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_display.c

index 376ec890c8fac278d0495cbfa16c86bd7e028ff4..3a088c03d7b9ae988ede013f9ef7eb1b1fcf3cfa 100644 (file)
@@ -11850,13 +11850,11 @@ intel_primary_plane_disable(struct drm_plane *plane)
         * In either case, we need to unpin the FB and let the fb pointer get
         * updated, but otherwise we don't need to touch the hardware.
         */
-       if (!intel_crtc->primary_enabled)
-               goto disable_unpin;
-
-       intel_crtc_wait_for_pending_flips(plane->crtc);
-       intel_disable_primary_hw_plane(plane, plane->crtc);
+       if (intel_crtc->primary_enabled) {
+               intel_crtc_wait_for_pending_flips(plane->crtc);
+               intel_disable_primary_hw_plane(plane, plane->crtc);
+       }
 
-disable_unpin:
        mutex_lock(&dev->struct_mutex);
        i915_gem_track_fb(intel_fb_obj(plane->fb), NULL,
                          INTEL_FRONTBUFFER_PRIMARY(intel_crtc->pipe));