]> git.dujemihanovic.xyz Git - linux.git/commitdiff
ARM: dts: exynos: correct TMU phandle in Odroid HC1
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thu, 9 Feb 2023 10:58:40 +0000 (11:58 +0100)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 17 Feb 2023 09:27:28 +0000 (10:27 +0100)
TMU node uses 0 as thermal-sensor-cells, thus thermal zone referencing
it must not have an argument to phandle.  This was not critical before,
but since rework of thermal Devicetree initialization in the
commit 3fd6d6e2b4e8 ("thermal/of: Rework the thermal device tree
initialization"), this leads to errors registering thermal zones other
than first one:

  thermal_sys: cpu0-thermal: Failed to read thermal-sensors cells: -2
  thermal_sys: Failed to find thermal zone for tmu id=0
  exynos-tmu 10064000.tmu: Failed to register sensor: -2
  exynos-tmu: probe of 10064000.tmu failed with error -2

Fixes: 1ac49427b566 ("ARM: dts: exynos: Add support for Hardkernel's Odroid HC1 board")
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20230209105841.779596-5-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
arch/arm/boot/dts/exynos5422-odroidhc1.dts

index 3de7019572a20397265356e0e3b63f08f36e2225..5e428039370677271953c6ecedd65d0950b8f5c8 100644 (file)
@@ -31,7 +31,7 @@
 
        thermal-zones {
                cpu0_thermal: cpu0-thermal {
-                       thermal-sensors = <&tmu_cpu0 0>;
+                       thermal-sensors = <&tmu_cpu0>;
                        trips {
                                cpu0_alert0: cpu-alert-0 {
                                        temperature = <70000>; /* millicelsius */
@@ -86,7 +86,7 @@
                        };
                };
                cpu1_thermal: cpu1-thermal {
-                       thermal-sensors = <&tmu_cpu1 0>;
+                       thermal-sensors = <&tmu_cpu1>;
                        trips {
                                cpu1_alert0: cpu-alert-0 {
                                        temperature = <70000>;
                        };
                };
                cpu2_thermal: cpu2-thermal {
-                       thermal-sensors = <&tmu_cpu2 0>;
+                       thermal-sensors = <&tmu_cpu2>;
                        trips {
                                cpu2_alert0: cpu-alert-0 {
                                        temperature = <70000>;
                        };
                };
                cpu3_thermal: cpu3-thermal {
-                       thermal-sensors = <&tmu_cpu3 0>;
+                       thermal-sensors = <&tmu_cpu3>;
                        trips {
                                cpu3_alert0: cpu-alert-0 {
                                        temperature = <70000>;
                        };
                };
                gpu_thermal: gpu-thermal {
-                       thermal-sensors = <&tmu_gpu 0>;
+                       thermal-sensors = <&tmu_gpu>;
                        trips {
                                gpu_alert0: gpu-alert-0 {
                                        temperature = <70000>;