]> git.dujemihanovic.xyz Git - linux.git/commitdiff
net: hsr: Don't log netdev_err message on unknown prp dst node
authorKristian Overskeid <koverskeid@gmail.com>
Tue, 7 Mar 2023 13:32:29 +0000 (14:32 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 14 Mar 2023 15:26:10 +0000 (15:26 +0000)
If no frames has been exchanged with a node for HSR_NODE_FORGET_TIME, the
node will be deleted from the node_db list. If a frame is sent to the node
after it is deleted, a netdev_err message for each slave interface is
produced. This should not happen with dan nodes because of supervision
frames, but can happen often with san nodes, which clutters the kernel
log. Since the hsr protocol does not support sans, this is only relevant
for the prp protocol.

Signed-off-by: Kristian Overskeid <koverskeid@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/hsr/hsr_framereg.c

index 00db74d96583d0f7b33b29697037b979f052c1d5..865eda39d60147eaa25caf84b4eaf10f1b2a3579 100644 (file)
@@ -415,7 +415,7 @@ void hsr_addr_subst_dest(struct hsr_node *node_src, struct sk_buff *skb,
        node_dst = find_node_by_addr_A(&port->hsr->node_db,
                                       eth_hdr(skb)->h_dest);
        if (!node_dst) {
-               if (net_ratelimit())
+               if (net_ratelimit() && port->hsr->prot_version != PRP_V1)
                        netdev_err(skb->dev, "%s: Unknown node\n", __func__);
                return;
        }