fbdev: Remove FBINFO_FLAG_DEFAULT from kzalloc()'ed structs

The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by kzalloc(). So do not
set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v4:
	* clarify commit message (Geert, Dan)
v2:
	* fix commit message (Miguel)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-14-tzimmermann@suse.de

diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
index e45338227be6e03e102b2cf06a95d5afffa21d13..24d89e6fb7805791f2d8b52e031ad6cd35595224 100644 (file)
--- a/drivers/video/fbdev/amba-clcd.c
+++ b/drivers/video/fbdev/amba-clcd.c
@@ -461,7 +461,6 @@ static int clcdfb_register(struct clcd_fb *fb)
        }
 
        fb->fb.fbops            = &clcdfb_ops;
-       fb->fb.flags            = FBINFO_FLAG_DEFAULT;
        fb->fb.pseudo_palette   = fb->cmap;
 
        strncpy(fb->fb.fix.id, clcd_name, sizeof(fb->fb.fix.id));

diff --git a/drivers/video/fbdev/matrox/matroxfb_crtc2.c b/drivers/video/fbdev/matrox/matroxfb_crtc2.c
index 7655afa3fd500b672ff1dae94b59472e5e75528e..372197c124dec4caadd72e27517b9f493eb6115c 100644 (file)
--- a/drivers/video/fbdev/matrox/matroxfb_crtc2.c
+++ b/drivers/video/fbdev/matrox/matroxfb_crtc2.c
@@ -603,9 +603,8 @@ static int matroxfb_dh_regit(const struct matrox_fb_info *minfo,
        void* oldcrtc2;
 
        m2info->fbcon.fbops = &matroxfb_dh_ops;
-       m2info->fbcon.flags = FBINFO_FLAG_DEFAULT;
-       m2info->fbcon.flags |= FBINFO_HWACCEL_XPAN |
-                              FBINFO_HWACCEL_YPAN;
+       m2info->fbcon.flags = FBINFO_HWACCEL_XPAN |
+                             FBINFO_HWACCEL_YPAN;
        m2info->fbcon.pseudo_palette = m2info->cmap;
        fb_alloc_cmap(&m2info->fbcon.cmap, 256, 1);