net: mvpp2: Don't re-use loop iterator

This function has a nested loop.  The problem is that both the inside
and outside loop use the same variable as an iterator.  I found this
via static analysis so I'm not sure the impact.  It could be that it
loops forever or, more likely, the loop exits early.

Fixes: 3a616b92a9d1 ("net: mvpp2: Add TX flow control support for jumbo frames")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/eaa8f403-7779-4d81-973d-a9ecddc0bf6f@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index 8c45ad983abc0c4b94a731a948dd6f56f48941ef..0d62a33afa80caf687e9175e4ed0d90ce054dc87 100644 (file)
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -953,13 +953,13 @@ static void mvpp2_bm_pool_update_fc(struct mvpp2_port *port,
 static void mvpp2_bm_pool_update_priv_fc(struct mvpp2 *priv, bool en)
 {
        struct mvpp2_port *port;
-       int i;
+       int i, j;
 
        for (i = 0; i < priv->port_count; i++) {
                port = priv->port_list[i];
                if (port->priv->percpu_pools) {
-                       for (i = 0; i < port->nrxqs; i++)
-                               mvpp2_bm_pool_update_fc(port, &port->priv->bm_pools[i],
+                       for (j = 0; j < port->nrxqs; j++)
+                               mvpp2_bm_pool_update_fc(port, &port->priv->bm_pools[j],
                                                        port->tx_fc & en);
                } else {
                        mvpp2_bm_pool_update_fc(port, port->pool_long, port->tx_fc & en);