]> git.dujemihanovic.xyz Git - linux.git/commitdiff
dmaengine: tegra210-adma: Using pm_runtime_resume_and_get to replace open coding
authorZhang Qilong <zhangqilong3@huawei.com>
Mon, 7 Jun 2021 06:46:40 +0000 (14:46 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 28 Jul 2021 07:24:38 +0000 (12:54 +0530)
use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
pm_runtime_put_noidle. this change is just to simplify the code,
there is no actual functional change.

Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20210607064640.121394-4-zhangqilong3@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/tegra210-adma.c

index 4735742e826d209b56dc3cfee9b33e1459f40f31..b1115a6d1935c4057a101f8a61a1704c153142d1 100644 (file)
@@ -655,9 +655,8 @@ static int tegra_adma_alloc_chan_resources(struct dma_chan *dc)
                return ret;
        }
 
-       ret = pm_runtime_get_sync(tdc2dev(tdc));
+       ret = pm_runtime_resume_and_get(tdc2dev(tdc));
        if (ret < 0) {
-               pm_runtime_put_noidle(tdc2dev(tdc));
                free_irq(tdc->irq, tdc);
                return ret;
        }
@@ -869,10 +868,8 @@ static int tegra_adma_probe(struct platform_device *pdev)
        pm_runtime_enable(&pdev->dev);
 
        ret = pm_runtime_get_sync(&pdev->dev);
-       if (ret < 0) {
-               pm_runtime_put_noidle(&pdev->dev);
+       if (ret < 0)
                goto rpm_disable;
-       }
 
        ret = tegra_adma_init(tdma);
        if (ret)