]> git.dujemihanovic.xyz Git - linux.git/commit
gve: Fix use of netif_carrier_ok()
authorPraveen Kaligineedi <pkaligineedi@google.com>
Thu, 1 Aug 2024 20:56:19 +0000 (13:56 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 2 Aug 2024 23:50:27 +0000 (16:50 -0700)
commitfba917b169bea5f8f2ee300e19d5f7a6341a5251
treeb943c03fdd522f1ce4cdaf6ebe3863364ea1b58b
parent89108cb5c28527c1882df2987394e5c261a1f4aa
gve: Fix use of netif_carrier_ok()

GVE driver wrongly relies on netif_carrier_ok() to check the
interface administrative state when resources are being
allocated/deallocated for queue(s). netif_carrier_ok() needs
to be replaced with netif_running() for all such cases.

Administrative state is the result of "ip link set dev <dev>
up/down". It reflects whether the administrator wants to use
the device for traffic and the corresponding resources have
been allocated.

Fixes: 5f08cd3d6423 ("gve: Alloc before freeing when adjusting queues")
Signed-off-by: Praveen Kaligineedi <pkaligineedi@google.com>
Reviewed-by: Shailend Chand <shailend@google.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/20240801205619.987396-1-pkaligineedi@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/google/gve/gve_ethtool.c
drivers/net/ethernet/google/gve/gve_main.c