]> git.dujemihanovic.xyz Git - linux.git/commit
bnxt_en: resize bnxt_irq name field to fit format string
authorEdwin Peer <edwin.peer@broadcom.com>
Mon, 9 Sep 2024 20:27:37 +0000 (13:27 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 11 Sep 2024 01:42:45 +0000 (18:42 -0700)
commitf77cdee5db06c6e4c30573889964c4cf1e3042a3
treec405ce15387e8835a9c71275481ae4488d3ac242
parent2d51eb0bd81cfbafc762592ede9e9234063cc853
bnxt_en: resize bnxt_irq name field to fit format string

The name field of struct bnxt_irq is written using snprintf in
bnxt_setup_msix(). Make the field large enough to fit the maximal
formatted string to prevent truncation.  Truncated IRQ names are
less meaningful to the user.  For example, "enp4s0f0np0-TxRx-0"
gets truncated to "enp4s0f0np0-TxRx-" with the existing code.

Make sure we have space for the extra characters added to the IRQ
names:

  - the characters introduced by the static format string: hyphens
  - the maximal static substituted ring type string: "TxRx"
  - the maximum length of an integer formatted as a string, even
    though reasonable ring numbers would never be as long as this.

Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240909202737.93852-4-michael.chan@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt.h