]> git.dujemihanovic.xyz Git - linux.git/commit
eeprom: at24: fix memory corruption race condition
authorDaniel Okazaki <dtokazaki@google.com>
Mon, 22 Apr 2024 17:43:36 +0000 (17:43 +0000)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 23 Apr 2024 08:07:48 +0000 (10:07 +0200)
commitf42c97027fb75776e2e9358d16bf4a99aeb04cf2
tree4d40c5c7bbdbe33a1c3cdcc432c96167bd244847
parentb3de7b433a323bb80303d77e69f1281bfab0a70b
eeprom: at24: fix memory corruption race condition

If the eeprom is not accessible, an nvmem device will be registered, the
read will fail, and the device will be torn down. If another driver
accesses the nvmem device after the teardown, it will reference
invalid memory.

Move the failure point before registering the nvmem device.

Signed-off-by: Daniel Okazaki <dtokazaki@google.com>
Fixes: b20eb4c1f026 ("eeprom: at24: drop unnecessary label")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20240422174337.2487142-1-dtokazaki@google.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/misc/eeprom/at24.c