]> git.dujemihanovic.xyz Git - linux.git/commit
drm/vc4: hdmi: Handle error case of pm_runtime_resume_and_get
authorStefan Wahren <wahrenst@gmx.net>
Wed, 21 Aug 2024 21:40:45 +0000 (23:40 +0200)
committerMaíra Canal <mcanal@igalia.com>
Thu, 22 Aug 2024 10:57:44 +0000 (07:57 -0300)
commitf1a54e860b1bc8d824925b5a77f510913880e8d6
tree18ee4f97ec419ecedd1afc4276d0b774fe5bebca
parent5e9c0d1c5ea355679f5b2a57b0c1b5932d78719d
drm/vc4: hdmi: Handle error case of pm_runtime_resume_and_get

The commit 0f5251339eda ("drm/vc4: hdmi: Make sure the controller is
powered in detect") introduced the necessary power management handling
to avoid register access while controller is powered down.
Unfortunately it just print a warning if pm_runtime_resume_and_get()
fails and proceed anyway.

This could happen during suspend to idle. So we must assume it is unsafe
to access the HDMI register. So bail out properly.

Fixes: 0f5251339eda ("drm/vc4: hdmi: Make sure the controller is powered in detect")
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Maíra Canal <mcanal@igalia.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Maíra Canal <mcanal@igalia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240821214052.6800-3-wahrenst@gmx.net
drivers/gpu/drm/vc4/vc4_hdmi.c