]> git.dujemihanovic.xyz Git - linux.git/commit
ice: fix pin phase adjust updates on PF reset
authorArkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Fri, 9 Feb 2024 21:24:32 +0000 (22:24 +0100)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 20 Feb 2024 18:26:24 +0000 (10:26 -0800)
commitee89921da471edcb4b1e67f5bbfedddf39749782
treea7924a90c4d270ea9bd0608727919e56a7f118f5
parent9a8385fe14bcb250a3889e744dc54e9c411d8400
ice: fix pin phase adjust updates on PF reset

Do not allow to set phase adjust value for a pin if PF reset is in
progress, this would cause confusing netlink extack errors as the firmware
cannot process the request properly during the reset time.

Return (-EBUSY) and report extack error for the user who tries configure
pin phase adjust during the reset time.

Test by looping execution of below steps until netlink error appears:
- perform PF reset
$ echo 1 > /sys/class/net/<ice PF>/device/reset
- change pin phase adjust value:
$ ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/dpll.yaml \
--do pin-set --json '{"id":0, "phase-adjust":1000}'

Fixes: 90e1c90750d7 ("ice: dpll: implement phase related callbacks")
Reviewed-by: Igor Bagnucki <igor.bagnucki@intel.com>
Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_dpll.c