]> git.dujemihanovic.xyz Git - linux.git/commit
selftests/net: fix uninitialized variables
authorJohn Hubbard <jhubbard@nvidia.com>
Mon, 6 May 2024 19:02:04 +0000 (12:02 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 8 May 2024 00:22:18 +0000 (17:22 -0700)
commiteb709b5f6536636dfb87b85ded0b2af9bb6cd9e6
tree4c556106ff5518a7a177fc8faa3ef9effdbae66b
parent0d5044b4e7749099b12da5f2c8618f04bb4fa82f
selftests/net: fix uninitialized variables

When building with clang, via:

    make LLVM=1 -C tools/testing/selftest

...clang warns about three variables that are not initialized in all
cases:

1) The opt_ipproto_off variable is used uninitialized if "testname" is
not "ip". Willem de Bruijn pointed out that this is an actual bug, and
suggested the fix that I'm using here (thanks!).

2) The addr_len is used uninitialized, but only in the assert case,
   which bails out, so this is harmless.

3) The family variable in add_listener() is only used uninitialized in
   the error case (neither IPv4 nor IPv6 is specified), so it's also
   harmless.

Fix by initializing each variable.

Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Acked-by: Mat Martineau <martineau@kernel.org>
Link: https://lore.kernel.org/r/20240506190204.28497-1-jhubbard@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/gro.c
tools/testing/selftests/net/ip_local_port_range.c
tools/testing/selftests/net/mptcp/pm_nl_ctl.c