]> git.dujemihanovic.xyz Git - linux.git/commit
Revert "r8169: don't try to disable interrupts if NAPI is, scheduled already"
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 15 May 2024 06:18:01 +0000 (08:18 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 21 May 2024 09:18:55 +0000 (11:18 +0200)
commiteabb8a9be1e4a12f3bf37ceb7411083e3775672d
tree489fe32cb7062d0e8b81cde3f6ce6184ccf04b50
parente4a87abf588536d1cdfb128595e6e680af5cf3ed
Revert "r8169: don't try to disable interrupts if NAPI is, scheduled already"

This reverts commit 7274c4147afbf46f45b8501edbdad6da8cd013b9.

Ken reported that RTL8125b can lock up if gro_flush_timeout has the
default value of 20000 and napi_defer_hard_irqs is set to 0.
In this scenario device interrupts aren't disabled, what seems to
trigger some silicon bug under heavy load. I was able to reproduce this
behavior on RTL8168h. Fix this by reverting 7274c4147afb.

Fixes: 7274c4147afb ("r8169: don't try to disable interrupts if NAPI is scheduled already")
Cc: stable@vger.kernel.org
Reported-by: Ken Milmore <ken.milmore@gmail.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/9b5b6f4c-4f54-4b90-b0b3-8d8023c2e780@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/realtek/r8169_main.c