]> git.dujemihanovic.xyz Git - linux.git/commit
selftests: net: csum: Fix checksums for packets with non-zero padding
authorSean Anderson <sean.anderson@linux.dev>
Fri, 6 Sep 2024 21:07:43 +0000 (17:07 -0400)
committerJakub Kicinski <kuba@kernel.org>
Tue, 10 Sep 2024 23:33:31 +0000 (16:33 -0700)
commite8a63d473b49011a68a748aea1c8aefa046ebacf
tree93843d6a2853221ad1e9f8a75bfa1ecec42adad6
parent3f62ea572b3e8e3f10c39a9cb4f04ca9ae5f2952
selftests: net: csum: Fix checksums for packets with non-zero padding

Padding is not included in UDP and TCP checksums. Therefore, reduce the
length of the checksummed data to include only the data in the IP
payload. This fixes spurious reported checksum failures like

rx: pkt: sport=33000 len=26 csum=0xc850 verify=0xf9fe
pkt: bad csum

Technically it is possible for there to be trailing bytes after the UDP
data but before the Ethernet padding (e.g. if sizeof(ip) + sizeof(udp) +
udp.len < ip.len). However, we don't generate such packets.

Fixes: 91a7de85600d ("selftests/net: add csum offload test")
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/20240906210743.627413-1-sean.anderson@linux.dev
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/lib/csum.c