]> git.dujemihanovic.xyz Git - linux.git/commit
nios2: Only use built-in devicetree blob if configured to do so
authorGuenter Roeck <linux@roeck-us.net>
Fri, 22 Mar 2024 06:54:19 +0000 (23:54 -0700)
committerRob Herring <robh@kernel.org>
Wed, 3 Apr 2024 19:35:53 +0000 (14:35 -0500)
commitde164a7f19248fb03229a4af9b0db333d9591e55
tree3149e10b312a9238ae7ee5e33a3ebc93b2bb14e5
parent500b42091c1dd878b7a8a59ef89aba85e0054b7b
nios2: Only use built-in devicetree blob if configured to do so

Starting with commit 7b937cc243e5 ("of: Create of_root if no dtb provided
by firmware"), attempts to boot nios2 images with an external devicetree
blob result in a crash.

Kernel panic - not syncing: early_init_dt_alloc_memory_arch:
Failed to allocate 72 bytes align=0x40

For nios2, a built-in devicetree blob always overrides devicetree blobs
provided by ROMMON/BIOS. This includes the new dummy devicetree blob.
Result is that the dummy devicetree blob is used even if an external
devicetree blob is provided. Since the dummy devicetree blob does not
include any memory information, memory allocations fail, resulting in
the crash.

To fix the problem, only use the built-in devicetree blob if
CONFIG_NIOS2_DTB_SOURCE_BOOL is enabled.

Fixes: 7b937cc243e5 ("of: Create of_root if no dtb provided by firmware")
Cc: Frank Rowand <frowand.list@gmail.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20240322065419.162416-1-linux@roeck-us.net
Signed-off-by: Rob Herring <robh@kernel.org>
arch/nios2/kernel/prom.c