]> git.dujemihanovic.xyz Git - linux.git/commit
net/mlx5: HWS, fixed double-free in error flow of creating SQ
authorYevgeny Kliteynik <kliteyn@nvidia.com>
Thu, 19 Sep 2024 09:17:59 +0000 (12:17 +0300)
committerSaeed Mahameed <saeedm@nvidia.com>
Wed, 25 Sep 2024 20:15:45 +0000 (13:15 -0700)
commitd8c561741ef83980114b3f7f95ffac54600f3f16
treedeeddd94316bbc2e281daaaab4828927e52ba23b
parent19da17010a55924f2b5540b0f61652cc5781af85
net/mlx5: HWS, fixed double-free in error flow of creating SQ

When SQ creation fails, call the appropriate mlx5_core destroy function.

This fixes the following smatch warnings:
  divers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_send.c:739
    hws_send_ring_open_sq() warn: 'sq->dep_wqe' double freed
    hws_send_ring_open_sq() warn: 'sq->wq_ctrl.buf.frags' double freed
    hws_send_ring_open_sq() warn: 'sq->wr_priv' double freed

Fixes: 2ca62599aa0b ("net/mlx5: HWS, added send engine and context handling")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/e4ebc227-4b25-49bf-9e4c-14b7ea5c6a07@stanley.mountain/
Signed-off-by: Yevgeny Kliteynik <kliteyn@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/steering/hws/mlx5hws_send.c