]> git.dujemihanovic.xyz Git - linux.git/commit
drm/vmwgfx: Sort primary plane formats by order of preference
authorZack Rusin <zack.rusin@broadcom.com>
Fri, 12 Apr 2024 02:55:11 +0000 (22:55 -0400)
committerZack Rusin <zack.rusin@broadcom.com>
Mon, 15 Apr 2024 15:48:57 +0000 (11:48 -0400)
commitd4c972bff3129a9dd4c22a3999fd8eba1a81531a
treee9e482344169e136544e2a1a2edde2c091bff99c
parenta60ccade88f926e871a57176e86a34bbf0db0098
drm/vmwgfx: Sort primary plane formats by order of preference

The table of primary plane formats wasn't sorted at all, leading to
applications picking our least desirable formats by defaults.

Sort the primary plane formats according to our order of preference.

Nice side-effect of this change is that it makes IGT's kms_atomic
plane-invalid-params pass because the test picks the first format
which for vmwgfx was DRM_FORMAT_XRGB1555 and uses fb's with odd sizes
which make Pixman, which IGT depends on assert due to the fact that our
16bpp formats aren't 32 bit aligned like Pixman requires all formats
to be.

Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
Fixes: 36cc79bc9077 ("drm/vmwgfx: Add universal plane support")
Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v4.12+
Acked-by: Pekka Paalanen <pekka.paalanen@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240412025511.78553-6-zack.rusin@broadcom.com
drivers/gpu/drm/vmwgfx/vmwgfx_kms.h