]> git.dujemihanovic.xyz Git - linux.git/commit
selftests/mm: ksm_tests should only MADV_HUGEPAGE valid memory
authorRyan Roberts <ryan.roberts@arm.com>
Mon, 22 Jan 2024 12:05:54 +0000 (12:05 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 26 Jan 2024 07:52:21 +0000 (23:52 -0800)
commitd021b442cf312664811783e92b3d5e4548e92a53
tree033d6f1afab88e3bef6f9f37c5a3512f565f4067
parent6f9dc684cae638dda0570154509884ee78d0f75c
selftests/mm: ksm_tests should only MADV_HUGEPAGE valid memory

ksm_tests was previously mmapping a region of memory, aligning the
returned pointer to a PMD boundary, then setting MADV_HUGEPAGE, but was
setting it past the end of the mmapped area due to not taking the pointer
alignment into consideration.  Fix this behaviour.

Up until commit efa7df3e3bb5 ("mm: align larger anonymous mappings on THP
boundaries"), this buggy behavior was (usually) masked because the
alignment difference was always less than PMD-size.  But since the
mentioned commit, `ksm_tests -H -s 100` started failing.

Link: https://lkml.kernel.org/r/20240122120554.3108022-1-ryan.roberts@arm.com
Fixes: 325254899684 ("selftests: vm: add KSM huge pages merging time test")
Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
Cc: Pedro Demarchi Gomes <pedrodemargomes@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
tools/testing/selftests/mm/ksm_tests.c