]> git.dujemihanovic.xyz Git - linux.git/commit
task_work: make TWA_NMI_CURRENT handling conditional on IRQ_WORK
authorLinus Torvalds <torvalds@linux-foundation.org>
Mon, 29 Jul 2024 19:05:06 +0000 (12:05 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 29 Jul 2024 19:05:06 +0000 (12:05 -0700)
commitcec6937dd1aae1b38d147bd190cb895d06cf96d0
tree971a172521f4d0d839a3737a8046b8a43c7d7601
parent2accfdb7eff65f390c4308b0e9cb7c3fe48ad63c
task_work: make TWA_NMI_CURRENT handling conditional on IRQ_WORK

The TWA_NMI_CURRENT handling very much depends on IRQ_WORK, but that
isn't universally enabled everywhere.

Maybe the IRQ_WORK infrastructure should just be unconditional - x86
ends up indirectly enabling it through unconditionally enabling
PERF_EVENTS, for example.  But it also gets enabled by having SMP
support, or even if you just have PRINTK enabled.

But in the meantime TWA_NMI_CURRENT causes tons of build failures on
various odd minimal configs.  Which did show up in linux-next, but
despite that nobody bothered to fix it or even inform me until -rc1 was
out.

Fixes: 466e4d801cd4 ("task_work: Add TWA_NMI_CURRENT as an additional notify mode")
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Reported-by: kernelci.org bot <bot@kernelci.org>
Reported-by: Guenter Roeck <linux@roeck-us.net>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/task_work.c