]> git.dujemihanovic.xyz Git - linux.git/commit
drm/amdgpu: fix tear down order in amdgpu_vm_pt_free
authorChristian König <christian.koenig@amd.com>
Fri, 8 Dec 2023 12:43:09 +0000 (13:43 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 13 Dec 2023 21:50:35 +0000 (16:50 -0500)
commitceb9a321e7639700844aa3bf234a4e0884f13b77
treea016d0f80d815a4400d16e8cd5f74c5560692a97
parent2c7300d357a213d4a4bda691d1d5c06251e552d0
drm/amdgpu: fix tear down order in amdgpu_vm_pt_free

When freeing PD/PT with shadows it can happen that the shadow
destruction races with detaching the PD/PT from the VM causing a NULL
pointer dereference in the invalidation code.

Fix this by detaching the the PD/PT from the VM first and then
freeing the shadow instead.

Signed-off-by: Christian König <christian.koenig@amd.com>
Fixes: https://gitlab.freedesktop.org/drm/amd/-/issues/2867
Cc: <stable@vger.kernel.org>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c