]> git.dujemihanovic.xyz Git - linux.git/commit
net: tc35815: rework network interface interrupt logic
authorChristian Marangi <ansuelsmth@gmail.com>
Mon, 9 Oct 2023 13:37:53 +0000 (15:37 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 12 Oct 2023 00:28:06 +0000 (17:28 -0700)
commitbe176234d0a845c075736490f34268b6a952c18f
tree1614ed7be6166de3cc4ae4d8bc471c38cb3e3349
parent73382e919f3d938554dadd01d95760f90d1c25c1
net: tc35815: rework network interface interrupt logic

Rework network interface logic. Before this change, the code flow was:
1. Disable interrupt
2. Try to schedule a NAPI
3. Check if it was possible (NAPI is not already scheduled)
4. emit BUG() if we receive interrupt while a NAPI is scheduled

If some application busy poll or set gro_flush_timeout low enough, it's
possible to reach the BUG() condition. Given that the condition may
happen and it wouldn't be a bug, rework the logic to permit such case
and prevent stall with interrupt never enabled again.

Disable the interrupt only if the NAPI can be scheduled (aka it's not
already scheduled) and drop the printk and BUG() call. With these
change, in the event of a NAPI already scheduled, the interrupt is
simply ignored with nothing done.

Suggested-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Link: https://lore.kernel.org/r/20231009133754.9834-4-ansuelsmth@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/toshiba/tc35815.c