]> git.dujemihanovic.xyz Git - linux.git/commit
drm/vmwgfx: Fix crtc's atomic check conditional
authorZack Rusin <zack.rusin@broadcom.com>
Fri, 12 Apr 2024 02:55:10 +0000 (22:55 -0400)
committerZack Rusin <zack.rusin@broadcom.com>
Mon, 15 Apr 2024 15:48:48 +0000 (11:48 -0400)
commita60ccade88f926e871a57176e86a34bbf0db0098
tree55a8864d192f2b19dea400fcd770e9a03946b7fe
parentb32233accefff1338806f064fb9b62cf5bc0609f
drm/vmwgfx: Fix crtc's atomic check conditional

The conditional was supposed to prevent enabling of a crtc state
without a set primary plane. Accidently it also prevented disabling
crtc state with a set primary plane. Neither is correct.

Fix the conditional and just driver-warn when a crtc state has been
enabled without a primary plane which will help debug broken userspace.

Fixes IGT's kms_atomic_interruptible and kms_atomic_transition tests.

Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
Fixes: 06ec41909e31 ("drm/vmwgfx: Add and connect CRTC helper functions")
Cc: Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v4.12+
Reviewed-by: Ian Forbes <ian.forbes@broadcom.com>
Reviewed-by: Martin Krastev <martin.krastev@broadcom.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240412025511.78553-5-zack.rusin@broadcom.com
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c