]> git.dujemihanovic.xyz Git - linux.git/commit
net: phy: marvell10g: fix differentiation of 88X3310 from 88X3340
authorMarek Behún <kabel@kernel.org>
Sun, 11 Jul 2021 16:38:15 +0000 (18:38 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 11 Jul 2021 17:02:33 +0000 (10:02 -0700)
commita5de4be0aaaa66a2fa98e8a33bdbed3bd0682804
tree0b772747329017f09b8698d3277063208cd763d3
parent84f7e0bb4809f4497124b6b6904c07c8a0c73c58
net: phy: marvell10g: fix differentiation of 88X3310 from 88X3340

It seems that we cannot differentiate 88X3310 from 88X3340 by simply
looking at bit 3 of revision ID. This only works on revisions A0 and A1.
On revision B0, this bit is always 1.

Instead use the 3.d00d register for differentiation, since this register
contains information about number of ports on the device.

Fixes: 9885d016ffa9 ("net: phy: marvell10g: add separate structure for 88X3340")
Signed-off-by: Marek Behún <kabel@kernel.org>
Reported-by: Matteo Croce <mcroce@linux.microsoft.com>
Tested-by: Matteo Croce <mcroce@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/marvell10g.c
include/linux/marvell_phy.h