]> git.dujemihanovic.xyz Git - linux.git/commit
net: mctp: put sock on tag allocation failure
authorJeremy Kerr <jk@codeconstruct.com.au>
Thu, 15 Feb 2024 07:53:08 +0000 (15:53 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 22 Feb 2024 01:01:54 +0000 (17:01 -0800)
commit9990889be14288d4f1743e4768222d5032a79c27
tree502a80a13e71457ed46f1d21e5a3eb396b9a6b99
parentf76d5f65805695afc65e4c265bd119b7e2e88442
net: mctp: put sock on tag allocation failure

We may hold an extra reference on a socket if a tag allocation fails: we
optimistically allocate the sk_key, and take a ref there, but do not
drop if we end up not using the allocated key.

Ensure we're dropping the sock on this failure by doing a proper unref
rather than directly kfree()ing.

Fixes: de8a6b15d965 ("net: mctp: add an explicit reference from a mctp_sk_key to sock")
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/ce9b61e44d1cdae7797be0c5e3141baf582d23a0.1707983487.git.jk@codeconstruct.com.au
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mctp/route.c