]> git.dujemihanovic.xyz Git - linux.git/commit
drm/xe: Protect devcoredump access after unbind
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Wed, 3 Apr 2024 19:50:44 +0000 (15:50 -0400)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 4 Apr 2024 18:53:22 +0000 (14:53 -0400)
commit972d01d0e357f3799203fa64ab696ac035e16803
treec34ce025ba911a86f727ac327302c69d9be8a31c
parent34820967ae7b45411f8f4f737c2d63b0c608e0d7
drm/xe: Protect devcoredump access after unbind

While we don't have the full flow protection when devcoredump
is accessed after device unbind. Let's at least for now
protect against null dereference:

[  422.766508] KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
[  423.119584] RIP: 0010:xe_vm_snapshot_free+0x30/0x180 [xe]

While at it, I also fixed a non-standard code-declaration block
on the similar function of xe_guc_submit.

v2: - Use IS_ERR_OR_NULL (Nirmoy)
    - Expand to other functions

Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240403195044.239766-1-rodrigo.vivi@intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_guc_submit.c
drivers/gpu/drm/xe/xe_vm.c