]> git.dujemihanovic.xyz Git - linux.git/commit
drm/exynos: fix accidental on-stack copy of exynos_drm_plane
authorArnd Bergmann <arnd@arndb.de>
Thu, 14 Dec 2023 12:32:15 +0000 (13:32 +0100)
committerInki Dae <inki.dae@samsung.com>
Mon, 22 Jan 2024 03:24:35 +0000 (12:24 +0900)
commit960b537e91725bcb17dd1b19e48950e62d134078
treeeeba1407cdcecf828578fab69e4cd4adf281489a
parent477552e1d339d9fa654a363c9c0f1e9c4f087d2b
drm/exynos: fix accidental on-stack copy of exynos_drm_plane

gcc rightfully complains about excessive stack usage in the fimd_win_set_pixfmt()
function:

drivers/gpu/drm/exynos/exynos_drm_fimd.c: In function 'fimd_win_set_pixfmt':
drivers/gpu/drm/exynos/exynos_drm_fimd.c:750:1: error: the frame size of 1032 bytes is larger than 1024 byte
drivers/gpu/drm/exynos/exynos5433_drm_decon.c: In function 'decon_win_set_pixfmt':
drivers/gpu/drm/exynos/exynos5433_drm_decon.c:381:1: error: the frame size of 1032 bytes is larger than 1024 bytes

There is really no reason to copy the large exynos_drm_plane
structure to the stack before using one of its members, so just
use a pointer instead.

Fixes: 6f8ee5c21722 ("drm/exynos: fimd: Make plane alpha configurable")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
drivers/gpu/drm/exynos/exynos5433_drm_decon.c
drivers/gpu/drm/exynos/exynos_drm_fimd.c