]> git.dujemihanovic.xyz Git - linux.git/commit
Drivers: hv: balloon: Use VMBUS_RING_SIZE() wrapper for dm_ring_size
authorBoqun Feng <boqun.feng@gmail.com>
Mon, 1 Nov 2021 15:00:26 +0000 (23:00 +0800)
committerWei Liu <wei.liu@kernel.org>
Mon, 15 Nov 2021 12:35:56 +0000 (12:35 +0000)
commit8a7eb2d476c6823cd44d8c25a6230a52417d7ef8
tree2e76b82414d922a8205b6db8689f2b32af52f956
parentfa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf
Drivers: hv: balloon: Use VMBUS_RING_SIZE() wrapper for dm_ring_size

Baihua reported an error when boot an ARM64 guest with PAGE_SIZE=64k and
BALLOON is enabled:

hv_vmbus: registering driver hv_balloon
hv_vmbus: probe failed for device 1eccfd72-4b41-45ef-b73a-4a6e44c12924 (-22)

The cause of this is that the ringbuffer size for hv_balloon is not
adjusted with VMBUS_RING_SIZE(), which makes the size not large enough
for ringbuffers on guest with PAGE_SIZE=64k. Therefore use
VMBUS_RING_SIZE() to calculate the ringbuffer size. Note that the old
size (20 * 1024) counts a 4k header in the total size, while
VMBUS_RING_SIZE() expects the parameter as the payload size, so use
16 * 1024.

Cc: <stable@vger.kernel.org> # 5.15.x
Reported-by: Baihua Lu <baihua.lu@microsoft.com>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Tested-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Link: https://lore.kernel.org/r/20211101150026.736124-1-boqun.feng@gmail.com
Signed-off-by: Wei Liu <wei.liu@kernel.org>
drivers/hv/hv_balloon.c