]> git.dujemihanovic.xyz Git - linux.git/commit
gpu: host1x: fix uninitialized variable use
authorArnd Bergmann <arnd@arndb.de>
Fri, 27 Jan 2023 22:14:00 +0000 (23:14 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 20 Mar 2023 18:12:37 +0000 (11:12 -0700)
commit7d31677bb7b1944ac89e9155110dc1b9acbb3895
tree5135ef21e144fd5567903bfd2777ca3176d7c10e
parent3d3699bde4b043eea17993e4e76804a8128f0fdb
gpu: host1x: fix uninitialized variable use

The error handling for platform_get_irq() failing no longer works after
a recent change, clang now points this out with a warning:

  drivers/gpu/host1x/dev.c:520:6: error: variable 'syncpt_irq' is uninitialized when used here [-Werror,-Wuninitialized]
          if (syncpt_irq < 0)
              ^~~~~~~~~~

Fix this by removing the variable and checking the correct error status.

Fixes: 625d4ffb438c ("gpu: host1x: Rewrite syncpoint interrupt handling")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/gpu/host1x/dev.c