]> git.dujemihanovic.xyz Git - linux.git/commit
net: atlantic: fix double free in ring reinit logic
authorIgor Russkikh <irusskikh@marvell.com>
Wed, 13 Dec 2023 09:40:44 +0000 (10:40 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 14 Dec 2023 11:10:59 +0000 (12:10 +0100)
commit7bb26ea74aa86fdf894b7dbd8c5712c5b4187da7
tree8f07f7db1c19ddf79d6d342bd43d347aa41a5cac
parent189ff16722ee36ced4d2a2469d4ab65a8fee4198
net: atlantic: fix double free in ring reinit logic

Driver has a logic leak in ring data allocation/free,
where double free may happen in aq_ring_free if system is under
stress and driver init/deinit is happening.

The probability is higher to get this during suspend/resume cycle.

Verification was done simulating same conditions with

    stress -m 2000 --vm-bytes 20M --vm-hang 10 --backoff 1000
    while true; do sudo ifconfig enp1s0 down; sudo ifconfig enp1s0 up; done

Fixed by explicitly clearing pointers to NULL on deallocation

Fixes: 018423e90bee ("net: ethernet: aquantia: Add ring support code")
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Closes: https://lore.kernel.org/netdev/CAHk-=wiZZi7FcvqVSUirHBjx0bBUZ4dFrMDVLc3+3HCrtq0rBA@mail.gmail.com/
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
Link: https://lore.kernel.org/r/20231213094044.22988-1-irusskikh@marvell.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/aquantia/atlantic/aq_ring.c