]> git.dujemihanovic.xyz Git - linux.git/commit
ALSA: hda/cs8409: Set PMSG_ON earlier inside cs8409 driver
authorStefan Binding <sbinding@opensource.cirrus.com>
Sun, 28 Nov 2021 11:55:58 +0000 (11:55 +0000)
committerTakashi Iwai <tiwai@suse.de>
Mon, 29 Nov 2021 08:22:56 +0000 (09:22 +0100)
commit65cc4ad62a9ed47c0b4fcd7af667d97d7c29f19d
treec232ec28b7271958a3e7d11590bccc5f8ef71f7e
parentdcd46eb7a9571c7d5c3b5da2699787f5bb8077d1
ALSA: hda/cs8409: Set PMSG_ON earlier inside cs8409 driver

For cs8409, it is required to run Jack Detect on resume.
Jack Detect on cs8409+cs42l42 requires an interrupt from
cs42l42 to be sent to cs8409 which is propogated to the driver
via an unsolicited event.
However, the hda_codec drops unsolicited events if the power_state
is not set to PMSG_ON. Which is set at the end of the resume call.
This means there is a race condition between setting power_state
to PMSG_ON and receiving the interrupt.
To solve this, we can add an API to set the power_state earlier
and call that before we start Jack Detect.
This does not cause issues, since we know inside our driver that
we are already initialized, and ready to handle the unsolicited
events.

Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
Signed-off-by: Vitaly Rodionov <vitalyr@opensource.cirrus.com>
Cc: <stable@vger.kernel.org> # v5.15+
Link: https://lore.kernel.org/r/20211128115558.71683-1-vitalyr@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_local.h
sound/pci/hda/patch_cs8409.c