]> git.dujemihanovic.xyz Git - linux.git/commit
media: atomisp: Fix streaming no longer working on BYT / ISP2400 devices
authorHans de Goede <hdegoede@redhat.com>
Sun, 21 Jul 2024 15:38:40 +0000 (17:38 +0200)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 14 Aug 2024 06:06:07 +0000 (08:06 +0200)
commit63de936b513f7a9ce559194d3269ac291f4f4662
tree2c4215baa4a139c215f87da8de6ca715ef599611
parent0c84bde4f37ba27d50e4c70ecacd33fe4a57030d
media: atomisp: Fix streaming no longer working on BYT / ISP2400 devices

Commit a0821ca14bb8 ("media: atomisp: Remove test pattern generator (TPG)
support") broke BYT support because it removed a seemingly unused field
from struct sh_css_sp_config and a seemingly unused value from enum
ia_css_input_mode.

But these are part of the ABI between the kernel and firmware on ISP2400
and this part of the TPG support removal changes broke ISP2400 support.

ISP2401 support was not affected because on ISP2401 only a part of
struct sh_css_sp_config is used.

Restore the removed field and enum value to fix this.

Fixes: a0821ca14bb8 ("media: atomisp: Remove test pattern generator (TPG) support")
Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/staging/media/atomisp/pci/ia_css_stream_public.h
drivers/staging/media/atomisp/pci/sh_css_internal.h