]> git.dujemihanovic.xyz Git - linux.git/commit
devlink: fix port dump cmd type
authorJiri Pirko <jiri@nvidia.com>
Tue, 20 Feb 2024 07:52:45 +0000 (08:52 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 22 Feb 2024 01:11:04 +0000 (17:11 -0800)
commit61c43780e9444123410cd48c2483e01d2b8f75e8
treefc99d12bb38bad89b65c1d2c1691ed242fe51f3a
parent90d07e36d40079a22ca99edd2412e7e9c2382968
devlink: fix port dump cmd type

Unlike other commands, due to a c&p error, port dump fills-up cmd with
wrong value, different from port-get request cmd, port-get doit reply
and port notification.

Fix it by filling cmd with value DEVLINK_CMD_PORT_NEW.

Skimmed through devlink userspace implementations, none of them cares
about this cmd value. Only ynl, for which, this is actually a fix, as it
expects doit and dumpit ops rsp_value to be the same.

Omit the fixes tag, even thought this is fix, better to target this for
next release.

Fixes: bfcd3a466172 ("Introduce devlink infrastructure")
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Link: https://lore.kernel.org/r/20240220075245.75416-1-jiri@resnulli.us
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/devlink/port.c