]> git.dujemihanovic.xyz Git - linux.git/commit
x86/csum: Remove unnecessary odd handling
authorNoah Goldstein <goldstein.w.n@gmail.com>
Sun, 24 Sep 2023 14:35:49 +0000 (09:35 -0500)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 4 Jan 2024 23:33:14 +0000 (15:33 -0800)
commit5d4acb62853abac1da2deebcb1c1c5b79219bf3b
treee8a8ec3331bbf87243bf233c425be341f5ee031a
parent5eff55d725a4e0dc6fc7709c4b1ca4fe40588d07
x86/csum: Remove unnecessary odd handling

The special case for odd aligned buffers is unnecessary and mostly
just adds overhead. Aligned buffers is the expectations, and even for
unaligned buffer, the only case that was helped is if the buffer was
1-byte from word aligned which is ~1/7 of the cases. Overall it seems
highly unlikely to be worth to extra branch.

It was left in the previous perf improvement patch because I was
erroneously comparing the exact output of `csum_partial(...)`, but
really we only need `csum_fold(csum_partial(...))` to match so its
safe to remove.

All csum kunit tests pass.

Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: David Laight <david.laight@aculab.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/x86/lib/csum-partial_64.c