]> git.dujemihanovic.xyz Git - linux.git/commit
selftests: mptcp: join: restrict fullmesh endp on 1st sf
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>
Tue, 10 Sep 2024 19:06:36 +0000 (21:06 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 11 Sep 2024 22:18:19 +0000 (15:18 -0700)
commit49ac6f05ace5bb0070c68a0193aa05d3c25d4c83
tree783037511e10c6a9e420f63e422aed458a33f088
parentd1aaaa2e0a6742b2bc4d851eb1a2b6390dbde2d9
selftests: mptcp: join: restrict fullmesh endp on 1st sf

A new endpoint using the IP of the initial subflow has been recently
added to increase the code coverage. But it breaks the test when using
old kernels not having commit 86e39e04482b ("mptcp: keep track of local
endpoint still available for each msk"), e.g. on v5.15.

Similar to commit d4c81bbb8600 ("selftests: mptcp: join: support local
endpoint being tracked or not"), it is possible to add the new endpoint
conditionally, by checking if "mptcp_pm_subflow_check_next" is present
in kallsyms: this is not directly linked to the commit introducing this
symbol but for the parent one which is linked anyway. So we can know in
advance what will be the expected behaviour, and add the new endpoint
only when it makes sense to do so.

Fixes: 4878f9f8421f ("selftests: mptcp: join: validate fullmesh endp on 1st sf")
Cc: stable@vger.kernel.org
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20240910-net-selftests-mptcp-fix-install-v1-1-8f124aa9156d@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/mptcp/mptcp_join.sh