]> git.dujemihanovic.xyz Git - linux.git/commit
Input: wistron_btns - use pm_sleep_ptr() to allow removal of ifdef CONFIG_PM guards
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 14 Jan 2023 17:16:20 +0000 (17:16 +0000)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 27 Jan 2023 22:49:53 +0000 (14:49 -0800)
commit47e79d310928ee21c0718cff5058251cd2dc71c0
treed705e522cef2c67a368b952f1258d9d02ca76daa
parentf33f61a75ad24b1bc14a8edf2f313f33ae54e5f2
Input: wistron_btns - use pm_sleep_ptr() to allow removal of ifdef CONFIG_PM guards

As the guards only apply to suspend and resume, #ifdef CONFIG_PM_SLEEP
would have been a tighter protection. As pm_sleep_ptr() lets the compiler
see the protected ops structure and callbacks but also lets the compiler
remove it as unused code if !CONFIG_PM_SLEEP this allows the #ifdef
guards to be removed, slightly simplifying the resulting code.

--
It seems likely that DEFINE_SIMPLE_DEV_PM_OPS() would work here but
I'd prefer not to make that change unless someone can confirm that the
extra callbacks registered will have no unwanted side effects in this
driver.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20230114171620.42891-17-jic23@kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/wistron_btns.c