]> git.dujemihanovic.xyz Git - linux.git/commit
platform/x86: thinkpad_acpi: Only update profile if successfully converted
authorMario Limonciello <mario.limonciello@amd.com>
Sat, 17 Feb 2024 02:23:11 +0000 (20:23 -0600)
committerHans de Goede <hdegoede@redhat.com>
Tue, 20 Feb 2024 13:35:36 +0000 (14:35 +0100)
commit427c70dec738318b7f71e1b9d829ff0e9771d493
treed7eea25f0e45f4c977a9e35d1542fb03f7d2c8ce
parent84c16d01ff219bc0a5dca5219db6b8b86a6854fb
platform/x86: thinkpad_acpi: Only update profile if successfully converted

Randomly a Lenovo Z13 will trigger a kernel warning traceback from this
condition:

```
if (WARN_ON((profile < 0) || (profile >= ARRAY_SIZE(profile_names))))
```

This happens because thinkpad-acpi always assumes that
convert_dytc_to_profile() successfully updated the profile. On the
contrary a condition can occur that when dytc_profile_refresh() is called
the profile doesn't get updated as there is a -EOPNOTSUPP branch.

Catch this situation and avoid updating the profile. Also log this into
dynamic debugging in case any other modes should be added in the future.

Fixes: c3bfcd4c6762 ("platform/x86: thinkpad_acpi: Add platform profile support")
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20240217022311.113879-1-mario.limonciello@amd.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/thinkpad_acpi.c