]> git.dujemihanovic.xyz Git - linux.git/commit
platform/x86: amd-pmc: Increase the response register timeout
authorMario Limonciello <mario.limonciello@amd.com>
Tue, 14 Sep 2021 02:01:14 +0000 (21:01 -0500)
committerHans de Goede <hdegoede@redhat.com>
Tue, 14 Sep 2021 10:26:00 +0000 (12:26 +0200)
commit3c3c8e88c8712bfe06cd10d7ca77a94a33610cd6
tree0562c2d55f5c9d47136e0ccb1e1a3e58b7bfbde2
parent196159d278ae3b49e7bbb7c76822e6008fd89b97
platform/x86: amd-pmc: Increase the response register timeout

There have been reports of approximately a 0.9%-1.7% failure rate in SMU
communication timeouts with s0i3 entry on some OEM designs.  Currently
the design in amd-pmc is to try every 100us for up to 20ms.

However the GPU driver which also communicates with the SMU using a
mailbox register which the driver polls every 1us for up to 2000ms.
In the GPU driver this was increased by commit 055162645a40 ("drm/amd/pm:
increase time out value when sending msg to SMU")

Increase the maximum timeout used by amd-pmc to 2000ms to match this
behavior.  This has been shown to improve the stability for machines
that randomly have failures.

Cc: stable@kernel.org
Reported-by: Julian Sikorski <belegdol@gmail.com>
BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1629
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Link: https://lore.kernel.org/r/20210914020115.655-1-mario.limonciello@amd.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/amd-pmc.c