]> git.dujemihanovic.xyz Git - linux.git/commit
sctp: fix a potential overflow in sctp_ifwdtsn_skip
authorXin Long <lucien.xin@gmail.com>
Mon, 10 Apr 2023 19:43:30 +0000 (15:43 -0400)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 13 Apr 2023 08:01:59 +0000 (10:01 +0200)
commit32832a2caf82663870126c5186cf8f86c8b2a649
treec53ebff8f60f06b37bd7b35c9aaacc3b270c931e
parent6417070918de3bcdbe0646e7256dae58fd8083ba
sctp: fix a potential overflow in sctp_ifwdtsn_skip

Currently, when traversing ifwdtsn skips with _sctp_walk_ifwdtsn, it only
checks the pos against the end of the chunk. However, the data left for
the last pos may be < sizeof(struct sctp_ifwdtsn_skip), and dereference
it as struct sctp_ifwdtsn_skip may cause coverflow.

This patch fixes it by checking the pos against "the end of the chunk -
sizeof(struct sctp_ifwdtsn_skip)" in sctp_ifwdtsn_skip, similar to
sctp_fwdtsn_skip.

Fixes: 0fc2ea922c8a ("sctp: implement validate_ftsn for sctp_stream_interleave")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Link: https://lore.kernel.org/r/2a71bffcd80b4f2c61fac6d344bb2f11c8fd74f7.1681155810.git.lucien.xin@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/sctp/stream_interleave.c