]> git.dujemihanovic.xyz Git - linux.git/commit
drm/panthor: Fix the FW reset logic
authorBoris Brezillon <boris.brezillon@collabora.com>
Tue, 30 Apr 2024 11:37:27 +0000 (13:37 +0200)
committerBoris Brezillon <boris.brezillon@collabora.com>
Thu, 2 May 2024 18:40:54 +0000 (20:40 +0200)
commit2fa42fd910c4ede1ae9c18d535b425046fa49351
tree8739b3874e583d14ef8d159c85de1644490958b3
parent8bdbd8b5580b46c8cae365567f5bf6cc956e6512
drm/panthor: Fix the FW reset logic

In the post_reset function, if the fast reset didn't succeed, we
are not clearing the fast_reset flag, which prevents firmware
sections from being reloaded. While at it, use panthor_fw_stop()
instead of manually writing DISABLE to the MCU_CONTROL register.

Fixes: 2718d91816ee ("drm/panthor: Add the FW logical block")
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240430113727.493155-1-boris.brezillon@collabora.com
drivers/gpu/drm/panthor/panthor_fw.c