]> git.dujemihanovic.xyz Git - linux.git/commit
drm/amd: Fix a probing order problem on SDMA 2.4
authorMario Limonciello <mario.limonciello@amd.com>
Tue, 12 Dec 2023 07:09:16 +0000 (01:09 -0600)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 13 Dec 2023 21:50:20 +0000 (16:50 -0500)
commit2c7300d357a213d4a4bda691d1d5c06251e552d0
tree1653f637c786ce46005095ef9618d754ba505edc
parentab4750332dbe535243def5dcebc24ca00c1f98ac
drm/amd: Fix a probing order problem on SDMA 2.4

commit 751e293f2c99 ("drm/amd: Move microcode init from sw_init to
early_init for SDMA v2.4") made a fateful mistake in
`adev->sdma.num_instances` wasn't declared when sdma_v2_4_init_microcode()
was run. This caused probing to fail.

Move the declaration to right before sdma_v2_4_init_microcode().

Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3043
Fixes: 751e293f2c99 ("drm/amd: Move microcode init from sw_init to early_init for SDMA v2.4")
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c