]> git.dujemihanovic.xyz Git - linux.git/commit
regulator: core: fix debugfs creation regression
authorJohan Hovold <johan+linaro@kernel.org>
Thu, 9 May 2024 13:33:04 +0000 (15:33 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 9 May 2024 15:43:57 +0000 (17:43 +0200)
commit2a4b49bb58123bad6ec0e07b02845f74c23d5e04
tree137521b4f3642a7bcaf6bd3db7e6d7f6260bd376
parentd1ef160b45a0010d1f1b3d601230457243a8f3e8
regulator: core: fix debugfs creation regression

regulator_get() may sometimes be called more than once for the same
consumer device, something which before commit dbe954d8f163 ("regulator:
core: Avoid debugfs: Directory ...  already present! error") resulted in
errors being logged.

A couple of recent commits broke the handling of such cases so that
attributes are now erroneously created in the debugfs root directory the
second time a regulator is requested and the log is filled with errors
like:

debugfs: File 'uA_load' in directory '/' already present!
debugfs: File 'min_uV' in directory '/' already present!
debugfs: File 'max_uV' in directory '/' already present!
debugfs: File 'constraint_flags' in directory '/' already present!

on any further calls.

Fixes: 2715bb11cfff ("regulator: core: Fix more error checking for debugfs_create_dir()")
Fixes: 08880713ceec ("regulator: core: Streamline debugfs operations")
Cc: stable@vger.kernel.org
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20240509133304.8883-1-johan+linaro@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/core.c