]> git.dujemihanovic.xyz Git - linux.git/commit
drm/amdkfd: Move queue fs deletion after destroy check
authorKent Russell <kent.russell@amd.com>
Tue, 10 Sep 2024 13:21:25 +0000 (09:21 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 17 Sep 2024 14:04:57 +0000 (10:04 -0400)
commit21d1d72475809734a5149ecfffdc7551503b042b
treeaaba63a564c1f8407713a840c6ce0e8d8b8d805b
parentae2c6d8b3b88c176dff92028941a4023f1b4cb91
drm/amdkfd: Move queue fs deletion after destroy check

We were removing the kernfs entry for queue info before checking if the
queue could be destroyed. If it failed to get destroyed (e.g. during
some GPU resets), then we would try to delete it later during pqm
teardown, but the file was already removed. This led to a kernel WARN
trying to remove size, gpuid and type. Move the remove to after the
destroy check.

Signed-off-by: Kent Russell <kent.russell@amd.com>
Reviewed-by: Jonathan Kim <jonathan.kim@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c