]> git.dujemihanovic.xyz Git - linux.git/commit
s390/qeth: Don't call dev_close/dev_open (DOWN/UP)
authorAlexandra Winter <wintera@linux.ibm.com>
Tue, 1 Aug 2023 08:00:16 +0000 (10:00 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 2 Aug 2023 09:12:51 +0000 (10:12 +0100)
commit1cfef80d4c2b2c599189f36f36320b205d9447d9
tree6421f77900eae35c9b173e0c9fcea9d1b356ef74
parent666c135b2d859a00ee74c8645b2affacfae45421
s390/qeth: Don't call dev_close/dev_open (DOWN/UP)

dev_close() and dev_open() are issued to change the interface state to DOWN
or UP (dev->flags IFF_UP). When the netdev is set DOWN it loses e.g its
Ipv6 addresses and routes. We don't want this in cases of device recovery
(triggered by hardware or software) or when the qeth device is set
offline.

Setting a qeth device offline or online and device recovery actions call
netif_device_detach() and/or netif_device_attach(). That will reset or
set the LOWER_UP indication i.e. change the dev->state Bit
__LINK_STATE_PRESENT. That is enough to e.g. cause bond failovers, and
still preserves the interface settings that are handled by the network
stack.

Don't call dev_open() nor dev_close() from the qeth device driver. Let the
network stack handle this.

Fixes: d4560150cb47 ("s390/qeth: call dev_close() during recovery")
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_core.h
drivers/s390/net/qeth_core_main.c
drivers/s390/net/qeth_l2_main.c
drivers/s390/net/qeth_l3_main.c