]> git.dujemihanovic.xyz Git - linux.git/commit
NFSD: Fix problem of COMMIT and NFS4ERR_DELAY in infinite loop
authorDai Ngo <dai.ngo@oracle.com>
Wed, 19 Apr 2023 17:53:18 +0000 (10:53 -0700)
committerChuck Lever <chuck.lever@oracle.com>
Thu, 27 Apr 2023 22:49:24 +0000 (18:49 -0400)
commit147abcacee33781e75588869e944ddb07528a897
tree6e59a3a97e865746f2e212cf6fc757402d23283c
parent695bc1f32c6bc806218b322096b23dfd601e59ca
NFSD: Fix problem of COMMIT and NFS4ERR_DELAY in infinite loop

The following request sequence to the same file causes the NFS client and
server getting into an infinite loop with COMMIT and NFS4ERR_DELAY:

OPEN
REMOVE
WRITE
COMMIT

Problem reported by recall11, recall12, recall14, recall20, recall22,
recall40, recall42, recall48, recall50 of nfstest suite.

This patch restores the handling of race condition in nfsd_file_do_acquire
with unlink to that prior of the regression.

Fixes: ac3a2585f018 ("nfsd: rework refcounting in filecache")
Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/filecache.c