]> git.dujemihanovic.xyz Git - linux.git/commit
net: bcmgenet: synchronize UMAC_CMD access
authorDoug Berger <opendmb@gmail.com>
Thu, 25 Apr 2024 22:27:21 +0000 (15:27 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 29 Apr 2024 05:24:22 +0000 (06:24 +0100)
commit0d5e2a82232605b337972fb2c7d0cbc46898aca1
tree093258eef2c8fc6285ee6e86654a426ffad2255f
parent2dbe5f19368caae63b1f59f5bc2af78c7d522b3a
net: bcmgenet: synchronize UMAC_CMD access

The UMAC_CMD register is written from different execution
contexts and has insufficient synchronization protections to
prevent possible corruption. Of particular concern are the
acceses from the phy_device delayed work context used by the
adjust_link call and the BH context that may be used by the
ndo_set_rx_mode call.

A spinlock is added to the driver to protect contended register
accesses (i.e. reg_lock) and it is used to synchronize accesses
to UMAC_CMD.

Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
Cc: stable@vger.kernel.org
Signed-off-by: Doug Berger <opendmb@gmail.com>
Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/genet/bcmgenet.c
drivers/net/ethernet/broadcom/genet/bcmgenet.h
drivers/net/ethernet/broadcom/genet/bcmgenet_wol.c
drivers/net/ethernet/broadcom/genet/bcmmii.c