]> git.dujemihanovic.xyz Git - linux.git/commit
btrfs: send: ensure send_fd is writable
authorJann Horn <jannh@google.com>
Fri, 24 Nov 2023 16:48:31 +0000 (17:48 +0100)
committerDavid Sterba <dsterba@suse.com>
Fri, 24 Nov 2023 17:50:53 +0000 (18:50 +0100)
commit0ac1d13a55eb37d398b63e6ff6db4a09a2c9128c
treefba242da216d9858ef320067bdc71c57c67e3fac
parent94dbf7c0871f7ae6349ba4b0341ce8f5f98a071d
btrfs: send: ensure send_fd is writable

kernel_write() requires the caller to ensure that the file is writable.
Let's do that directly after looking up the ->send_fd.

We don't need a separate bailout path because the "out" path already
does fput() if ->send_filp is non-NULL.

This has no security impact for two reasons:

 - the ioctl requires CAP_SYS_ADMIN
 - __kernel_write() bails out on read-only files - but only since 5.8,
   see commit a01ac27be472 ("fs: check FMODE_WRITE in __kernel_write")

Reported-and-tested-by: syzbot+12e098239d20385264d3@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=12e098239d20385264d3
Fixes: 31db9f7c23fb ("Btrfs: introduce BTRFS_IOC_SEND for btrfs send/receive")
CC: stable@vger.kernel.org # 4.14+
Signed-off-by: Jann Horn <jannh@google.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/send.c