]> git.dujemihanovic.xyz Git - linux.git/commit
cifs: do not depend on release_iface for maintaining iface_list
authorShyam Prasad N <sprasad@microsoft.com>
Fri, 29 Dec 2023 11:16:16 +0000 (11:16 +0000)
committerSteve French <stfrench@microsoft.com>
Fri, 29 Dec 2023 15:11:26 +0000 (09:11 -0600)
commit09eeb0723f219fbd96d8865bf9b935e03ee2ec22
tree467a8e35acae6b2259895f56bb4af14913a54796
parent7257bcf3bdc785eabc4eef1f329a59815b032508
cifs: do not depend on release_iface for maintaining iface_list

parse_server_interfaces should be in complete charge of maintaining
the iface_list linked list. Today, iface entries are removed
from the list only when the last refcount is dropped.
i.e. in release_iface. However, this can result in undercounting
of refcount if the server stops advertising interfaces (which
Azure SMB server does).

This change puts parse_server_interfaces in full charge of
maintaining the iface_list. So if an empty list is returned
by the server, the entries in the list will immediately be
removed. This way, a following call to the same function will
not find entries in the list.

Fixes: aa45dadd34e4 ("cifs: change iface_list from array to sorted linked list")
Cc: stable@vger.kernel.org
Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/cifsglob.h
fs/smb/client/smb2ops.c