]> git.dujemihanovic.xyz Git - linux.git/commit
ext4: mark fc as ineligible using an handle in ext4_xattr_set()
authorLuis Henriques (SUSE) <luis.henriques@linux.dev>
Mon, 23 Sep 2024 10:49:09 +0000 (11:49 +0100)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 4 Oct 2024 21:36:09 +0000 (17:36 -0400)
commit04e6ce8f06d161399e5afde3df5dcfa9455b4952
tree2405796fda222ce24bec452f8a8dc5941b508803
parentfaab35a0370fd6e0821c7a8dd213492946fc776f
ext4: mark fc as ineligible using an handle in ext4_xattr_set()

Calling ext4_fc_mark_ineligible() with a NULL handle is racy and may result
in a fast-commit being done before the filesystem is effectively marked as
ineligible.  This patch moves the call to this function so that an handle
can be used.  If a transaction fails to start, then there's not point in
trying to mark the filesystem as ineligible, and an error will eventually be
returned to user-space.

Suggested-by: Jan Kara <jack@suse.cz>
Signed-off-by: Luis Henriques (SUSE) <luis.henriques@linux.dev>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20240923104909.18342-3-luis.henriques@linux.dev
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
fs/ext4/xattr.c