From: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Date: Mon, 29 Jan 2024 17:01:27 +0000 (+0100)
Subject: cmd: smbios: replace missing string by 'Not Specified'
X-Git-Url: http://git.dujemihanovic.xyz/posts?a=commitdiff_plain;h=c11f176ab16a3488c0b057fed41d76ef96091564;p=u-boot.git

cmd: smbios: replace missing string by 'Not Specified'

A missing string value is indicated by a string index of 0. In this case
print 'Not Specified' like the Linux dmidecode command does.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---

diff --git a/cmd/smbios.c b/cmd/smbios.c
index 62935ecd1a..95bdff6026 100644
--- a/cmd/smbios.c
+++ b/cmd/smbios.c
@@ -25,6 +25,10 @@ static const char *smbios_get_string(void *table, int index)
 {
 	const char *str = (char *)table +
 			  ((struct smbios_header *)table)->length;
+	static const char fallback[] = "Not Specified";
+
+	if (!index)
+		return fallback;
 
 	if (!*str)
 		++str;
@@ -41,7 +45,7 @@ static struct smbios_header *next_table(struct smbios_header *table)
 	if (table->type == SMBIOS_END_OF_TABLE)
 		return NULL;
 
-	str = smbios_get_string(table, 0);
+	str = smbios_get_string(table, -1);
 	return (struct smbios_header *)(++str);
 }